Open
Conversation
anurag-amx
requested changes
Jul 13, 2023
anurag-amx
left a comment
There was a problem hiding this comment.
- Provide Description of PR.
- What is version upgrade version="1.3.5" and what is the impact. How did you make sure all functionalities are working fine.
Author
|
Added |
Author
I did testing from my end, along with all the functionalities and it is working fine.. |
|
Please mention in description what's all package removed? |
Author
Added |
anurag-amx
approved these changes
Jul 21, 2023
gulshan178
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading the version list of changes done:
Removing some packages Which are not in use i.e, cryptography==41.0.1, pycrypto==2.6.1
upgrading the requirements_dev by the recent packages of the smartapi-python.
so that their dist and bdist file be updated with recent changes.